🌱 bump Go version to 1.21.8 #2817
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
adityabhatia
force-pushed
the
bumpGo1.21.8
branch
from
95fbde2
to
97d0391
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
==========================================
+ Coverage 64.00% 64.07% +0.07%
==========================================
Files 160 160
Lines 9367 9367
==========================================
+ Hits 5995 6002 +7
+ Misses 2913 2909 -4
+ Partials 459 456 -3 ☔ View full report in Codecov by Sentry. |
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module sigs.k8s.io/cluster-api-provider-vsphere | |||
|
|
|||
| go 1.21 | |||
| go 1.21.8 | |||
There was a problem hiding this comment.
| go 1.21.8 | |
| go 1.21 |
The go directive shouldn't contain a patch version
There was a problem hiding this comment.
Usually this is the case but I faced problems there when the unintended go version bump to 1.22. was made https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-vsphere/2814/pull-cluster-api-provider-vsphere-apidiff-main/1767971030099300352
As an intermediate solution I tried what was mentioned here golang/go#65568, not sure why
There was a problem hiding this comment.
We'll get back to that when we bump to 1.22 :)
There was a problem hiding this comment.
Read through this doc: https://go.dev/doc/toolchain. I think e.g. 1.22.0 is fine going forward
Any two Go versions can be compared to decide whether one is less than, greater than, or equal to the other. If the language versions are different, that decides the comparison: 1.21.9 < 1.22. Within a language version, the ordering from least to greatest is: the language version itself, then release candidates ordered by R, then releases ordered by P.
For example, 1.21 < 1.21rc1 < 1.21rc2 < 1.21.0 < 1.21.1 < 1.21.2.
Before Go 1.21, the initial release of a Go toolchain was version 1.N, not 1.N.0, so for N < 21, the ordering is adjusted to place 1.N after the release candidates.
Specifying 1.22.0 as min version should mean that RC's are not good enough
There was a problem hiding this comment.
I think this explains your issue. 1.22 is simply not an existing toolchain
The standard Go toolchains are named goV where V is a Go version denoting a beta release, release candidate, or release. For example, go1.21rc1 and go1.21.0 are toolchain names; go1.21 and go1.22 are not (the initial releases are go1.21.0 and go1.22.0), but go1.20 and go1.19 are.
There was a problem hiding this comment.
Sounds like it, thanks for the clarification 👍
|
/cherry-pick release-1.9 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.8 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.7 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
test/go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module sigs.k8s.io/cluster-api-provider-vsphere/test | |||
|
|
|||
| go 1.21 | |||
| go 1.21.8 | |||
There was a problem hiding this comment.
| go 1.21.8 | |
| go 1.21 |
Same here
adityabhatia
force-pushed
the
bumpGo1.21.8
branch
from
97d0391
to
504b1c8
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: cd495de7275fe3e5e12c3d98ba95ddbcca663dea
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #2818 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sbueringer: new pull request created: #2819 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sbueringer: new pull request created: #2820 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Partially solves failing CVE jobs https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/actions/runs/8232381773/job/22509705921