🐛 Ensure entries for ProviderServiceAccount created in the ConfigMap are cleaned up

[fabriziopandini]

What this PR does / why we need it:
Ensure entries for ProviderServiceAccount created in the ConfigMap are cleaned up by adding a finalizer on the vSphereCluster

Which issue(s) this PR fixes:
Fixes #2845

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.09%. Comparing base (cb1635c) to head (8132829).
Report is 6 commits behind head on main.

Files	Patch %	Lines
controllers/serviceaccount_controller.go	50.00%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2846      +/-   ##
==========================================
- Coverage   64.20%   64.09%   -0.11%     
==========================================
  Files         160      160              
  Lines        9367     9375       +8     
==========================================
- Hits         6014     6009       -5     
- Misses       2899     2909      +10     
- Partials      454      457       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrischdi]

Only the naming thing, as of that lgtm

[sbueringer]

Thx!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: b3c63ebfb7a1bb298e30d736f79200786d4f7d44

[fabriziopandini]

/cherry-pick release-1.9

[fabriziopandini]

/cherry-pick release-1.8

[fabriziopandini]

/cherry-pick release-1.7

[fabriziopandini]

/cherry-pick release-1.6

[k8s-infra-cherrypick-robot]

@fabriziopandini: #2846 failed to apply on top of branch "release-1.8":

Applying: Ensure entries for ProviderServiceAccount created in the ConfigMap are cleaned up
Using index info to reconstruct a base tree...
M	apis/vmware/v1beta1/vspherecluster_types.go
M	controllers/serviceaccount_controller.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/serviceaccount_controller.go
CONFLICT (content): Merge conflict in controllers/serviceaccount_controller.go
Auto-merging apis/vmware/v1beta1/vspherecluster_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ensure entries for ProviderServiceAccount created in the ConfigMap are cleaned up
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@fabriziopandini: new pull request created: #2849

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@fabriziopandini: #2846 failed to apply on top of branch "release-1.7":

Applying: Ensure entries for ProviderServiceAccount created in the ConfigMap are cleaned up
Using index info to reconstruct a base tree...
M	apis/vmware/v1beta1/vspherecluster_types.go
M	controllers/serviceaccount_controller.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/serviceaccount_controller.go
CONFLICT (content): Merge conflict in controllers/serviceaccount_controller.go
Auto-merging apis/vmware/v1beta1/vspherecluster_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ensure entries for ProviderServiceAccount created in the ConfigMap are cleaned up
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@fabriziopandini: #2846 failed to apply on top of branch "release-1.6":

Applying: Ensure entries for ProviderServiceAccount created in the ConfigMap are cleaned up
Using index info to reconstruct a base tree...
M	apis/vmware/v1beta1/vspherecluster_types.go
M	controllers/serviceaccount_controller.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/serviceaccount_controller.go
CONFLICT (content): Merge conflict in controllers/serviceaccount_controller.go
Auto-merging apis/vmware/v1beta1/vspherecluster_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ensure entries for ProviderServiceAccount created in the ConfigMap are cleaned up
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.