-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Revert "Replace deprecated wait functions" #2860
🌱 Revert "Replace deprecated wait functions" #2860
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2860 +/- ##
==========================================
- Coverage 63.98% 63.87% -0.12%
==========================================
Files 160 160
Lines 9375 9375
==========================================
- Hits 5999 5988 -11
- Misses 2916 2925 +9
- Partials 460 462 +2 ☔ View full report in Codecov by Sentry. |
lgtm +/- linter |
Still disagrees 🤔 |
@fabriziopandini @chrischdi Let's merge #2868 first. Otherwise we'll have to add the nolint in this PR and need another PR after the bump to drop the nolint comments |
5c24e8a
to
3ff8bf7
Compare
/lgtm |
LGTM label has been added. Git tree hash: 3c8d183e342200ada5e91d8a5484ca237b6db7d3
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
As per comments in vmware/govmomi#3394, we are going back to use thread-safe functions
task.Wait
andtask.WaitForResult
.Deprecation notice is going to be removed in a future version of govmomi