Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Revert "Replace deprecated wait functions" #2860

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
As per comments in vmware/govmomi#3394, we are going back to use thread-safe functions task.Wait and task.WaitForResult.
Deprecation notice is going to be removed in a future version of govmomi

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.87%. Comparing base (5205edb) to head (3ff8bf7).

Files Patch % Lines
pkg/services/govmomi/util.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
- Coverage   63.98%   63.87%   -0.12%     
==========================================
  Files         160      160              
  Lines        9375     9375              
==========================================
- Hits         5999     5988      -11     
- Misses       2916     2925       +9     
- Partials      460      462       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbueringer
Copy link
Member

lgtm +/- linter

@chrischdi
Copy link
Member

Still disagrees 🤔

@sbueringer
Copy link
Member

@fabriziopandini @chrischdi Let's merge #2868 first.

Otherwise we'll have to add the nolint in this PR and need another PR after the bump to drop the nolint comments

@fabriziopandini fabriziopandini force-pushed the revert-replace-deprecated-wait-functions branch from 5c24e8a to 3ff8bf7 Compare April 2, 2024 15:16
@chrischdi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c8d183e342200ada5e91d8a5484ca237b6db7d3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit f9fd1a9 into kubernetes-sigs:main Apr 2, 2024
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Apr 2, 2024
@fabriziopandini fabriziopandini deleted the revert-replace-deprecated-wait-functions branch April 18, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants