🌱 Add env variables for ClusterCacheTracker #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Büringer buringerst@vmware.com
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2869 +/- ##
==========================================
+ Coverage 63.89% 64.04% +0.14%
==========================================
Files 160 160
Lines 9375 9375
==========================================
+ Hits 5990 6004 +14
+ Misses 2923 2912 -11
+ Partials 462 459 -3 ☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2cce1ca9a71da65e4bcad2daecf7aa9b526300fe
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
If set, CCT uses these variables to figure out if it tries to communicate with the cluster it's running on. If that's the case it will use
kubernetes.default.svcinstead of the regular external control plane endpoint(jut noticed when reading CAPI release notes of the last few years :))
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #