Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Makefile: fix release-notes generator arguments #2873

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Fixes the arguments for release-notes generator which got bumped by bumping the CAPI dependency in Makefile.

  • Removes the --pre-release-version=$(PRE_RELEASE) argument
  • When RELEASE_TAG is a pre-release (contains -), then add the --previous-release-version argument:
    • the previous-release-version gets calculated using the following pipeline
    • list all tags (git tag -l)
    • grep for .0 releases and releases which are on the same major/minor version as RELEASE_TAG
    • sort by version
    • return the tag which is in the list right before RELEASE_TAG

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.03%. Comparing base (47f8878) to head (aad81b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
- Coverage   64.23%   64.03%   -0.21%     
==========================================
  Files         160      160              
  Lines        9367     9367              
==========================================
- Hits         6017     5998      -19     
- Misses       2897     2910      +13     
- Partials      453      459       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7acfa4f36d3c4dd77f1807d0e0d11b7c39e1eb85

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7487d02 into kubernetes-sigs:main Apr 3, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Apr 3, 2024
@chrischdi chrischdi deleted the pr-fix-release-notes-generator branch April 3, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants