-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Enhancement of Error Handling and Network Status Verification for NSXT #2902
🌱 Enhancement of Error Handling and Network Status Verification for NSXT #2902
Conversation
|
Hi @silvery1622. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4efbf97
to
1a790e9
Compare
1a790e9
to
4009b08
Compare
/ok-to-test |
Thank you for following up! /lgtm /assign @chrischdi |
LGTM label has been added. Git tree hash: 19bd42654c6dc6dca486ef5301752c472c7041b1
|
Upload downstream test log: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refactored verifyNSXTVirtualNetworkStatus method to enhance error handling and network status verification.
What this PR does / why we need it:
Introduced hasReadyCondition flag to track 'Ready' condition in VirtualNetwork.Status and adjusted marking of ClusterNetworkReadyCondition accordingly.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2901