Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Enhancement of Error Handling and Network Status Verification for NSXT #2902

Merged

Conversation

silvery1622
Copy link
Contributor

Refactored verifyNSXTVirtualNetworkStatus method to enhance error handling and network status verification.

What this PR does / why we need it:
Introduced hasReadyCondition flag to track 'Ready' condition in VirtualNetwork.Status and adjusted marking of ClusterNetworkReadyCondition accordingly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2901

Copy link

linux-foundation-easycla bot commented Apr 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @silvery1622. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2024
@silvery1622 silvery1622 changed the title 🌱 Enhancement of Error Handling and Network Status Verification for NSXT [WIP]🌱 Enhancement of Error Handling and Network Status Verification for NSXT Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
@silvery1622 silvery1622 force-pushed the fix-nsxt-networkstatus-notset branch from 4efbf97 to 1a790e9 Compare April 11, 2024 10:47
@silvery1622 silvery1622 force-pushed the fix-nsxt-networkstatus-notset branch from 1a790e9 to 4009b08 Compare April 11, 2024 10:50
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 11, 2024
@silvery1622 silvery1622 changed the title [WIP]🌱 Enhancement of Error Handling and Network Status Verification for NSXT 🌱 Enhancement of Error Handling and Network Status Verification for NSXT Apr 11, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
@chrischdi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2024
@sbueringer
Copy link
Member

Thank you for following up!

/lgtm

/assign @chrischdi

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 19bd42654c6dc6dca486ef5301752c472c7041b1

@silvery1622
Copy link
Contributor Author

silvery1622 commented Apr 12, 2024

Upload downstream test log:
resource.log
capv-controller-manager-1.log
capv-controller-manager-2.log

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 13dade4 into kubernetes-sigs:main Apr 12, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring and Improved Error Checking in Verification of NSXT VirtualNetwork Status
4 participants