ValidateCommonFields should be private

kubernetes-sigs · Aug 14, 2023 · 12eaa07 · 12eaa07
1 parent ba76c78
commit 12eaa07
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/webhooks/clusterclass.go b/internal/webhooks/clusterclass.go
@@ -366,7 +366,7 @@ func validateMachineHealthCheckClass(fldPath *field.Path, namepace string, m *cl
 			RemediationTemplate: m.RemediationTemplate,
 		}}
 
-	return (&MachineHealthCheck{}).ValidateCommonFields(&mhc, fldPath)
+	return (&MachineHealthCheck{}).validateCommonFields(&mhc, fldPath)
 }
 
 func validateClusterClassMetadata(clusterClass *clusterv1.ClusterClass) field.ErrorList {

diff --git a/internal/webhooks/machinehealthcheck.go b/internal/webhooks/machinehealthcheck.go
@@ -157,7 +157,7 @@ func (webhook *MachineHealthCheck) validate(oldMHC, newMHC *clusterv1.MachineHea
 		)
 	}
 
-	allErrs = append(allErrs, webhook.ValidateCommonFields(newMHC, specPath)...)
+	allErrs = append(allErrs, webhook.validateCommonFields(newMHC, specPath)...)
 
 	if len(allErrs) == 0 {
 		return nil
@@ -167,7 +167,7 @@ func (webhook *MachineHealthCheck) validate(oldMHC, newMHC *clusterv1.MachineHea
 
 // ValidateCommonFields validates UnhealthyConditions NodeStartupTimeout, MaxUnhealthy, and RemediationTemplate of the MHC.
 // These are the fields in common with other types which define MachineHealthChecks such as MachineHealthCheckClass and MachineHealthCheckTopology.
-func (webhook *MachineHealthCheck) ValidateCommonFields(m *clusterv1.MachineHealthCheck, fldPath *field.Path) field.ErrorList {
+func (webhook *MachineHealthCheck) validateCommonFields(m *clusterv1.MachineHealthCheck, fldPath *field.Path) field.ErrorList {
 	var allErrs field.ErrorList
 
 	if m.Spec.NodeStartupTimeout != nil &&