Merge pull request #9388 from sbueringer/pr-fail-on-version-check

🌱 Fail tests if test env version check fails
kubernetes-sigs · Sep 11, 2023 · 321096f · 321096f
2 parents 826494a + a1e9969
commit 321096f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/test/envtest/environment.go b/internal/test/envtest/environment.go
@@ -143,11 +143,11 @@ func Run(ctx context.Context, input RunInput) int {
 
 	if input.MinK8sVersion != "" {
 		if err := version.CheckKubernetesVersion(env.Config, input.MinK8sVersion); err != nil {
-			fmt.Printf("[IMPORTANT] skipping tests after failing version check: %v\n", err)
+			fmt.Printf("[ERROR] Cannot run tests after failing version check: %v\n", err)
 			if err := env.stop(); err != nil {
 				fmt.Println("[WARNING] Failed to stop the test environment")
 			}
-			return 0
+			return 1
 		}
 	}