Skip to content

Commit

Permalink
Remove the Secret's OwnerReferences before pivot
Browse files Browse the repository at this point in the history
  • Loading branch information
tahsinrahman committed Sep 12, 2019
1 parent fc4f55e commit 409ba25
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions cmd/clusterctl/phases/pivot.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,12 @@ func moveSecret(from sourceClient, to targetClient, secret *corev1.Secret) error
// New objects cannot have a specified resource version. Clear it out.
secret.SetResourceVersion("")

// Remove owner reference.
secret.SetOwnerReferences(nil)
// Remove owner reference only if they're part of our known APIGroup
for _, ownerRef := range secret.OwnerReferences {
if ownerRef.APIVersion == clusterv1.GroupVersion.String() {
secret.SetOwnerReferences(nil)
}
}

if err := to.CreateSecret(secret); err != nil {
return errors.Wrapf(err, "error copying Secret %s/%s to target cluster", secret.Namespace, secret.Name)
Expand Down

0 comments on commit 409ba25

Please sign in to comment.