Add the node's UID to the machine's noderef.

kubernetes-sigs · Jun 14, 2018 · 46718d6 · 46718d6
1 parent ca0cee6
commit 46718d6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/pkg/controller/machine/node.go b/pkg/controller/machine/node.go
@@ -151,8 +151,10 @@ func (c *MachineControllerImpl) reconcileNode(key string) error {
 }
 
 func objectRef(node *corev1.Node) *corev1.ObjectReference {
+	glog.Errorf("updating object reference for node: %v, %v", node.ObjectMeta.Name, node.UID)
 	return &corev1.ObjectReference{
 		Kind: "Node",
 		Name: node.ObjectMeta.Name,
+		UID:  node.UID,
 	}
 }
diff --git a/pkg/controller/machine/node_test.go b/pkg/controller/machine/node_test.go
@@ -137,6 +137,7 @@ func TestReconcileNode(t *testing.T) {
 			node := &corev1.Node{
 				ObjectMeta: metav1.ObjectMeta{
 					Name:        "bar",
+					UID:         "the-uid",
 					Annotations: make(map[string]string),
 				},
 			}
@@ -240,6 +241,9 @@ func TestReconcileNode(t *testing.T) {
 				if actualMachine.Status.NodeRef.Name != "bar" {
 					t.Errorf("got %v node ref name, expected bar node ref name.", actualMachine.Status.NodeRef.Name)
 				}
+				if actualMachine.Status.NodeRef.UID != "the-uid" {
+					t.Errorf("got '%v' node ref uid, expected 'the-uid' node ref uid", actualMachine.Status.NodeRef.UID)
+				}
 			}
 			if !test.expectLinked {
 				if actualMachine != nil && actualMachine.Status.NodeRef != nil {