drop unused runtime features for the inmemory provider

kubernetes-sigs · Nov 27, 2023 · 476bf18 · 476bf18
1 parent d6d3d1f
commit 476bf18
Show file tree

Hide file tree

Showing 26 changed files with 8 additions and 1,376 deletions.
diff --git a/test/infrastructure/inmemory/internal/cloud/alias.go b/test/infrastructure/inmemory/internal/cloud/alias.go
@@ -19,7 +19,6 @@ package cloud
 import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
-	cbuilder "sigs.k8s.io/cluster-api/test/infrastructure/inmemory/internal/cloud/runtime/builder"
 	cclient "sigs.k8s.io/cluster-api/test/infrastructure/inmemory/internal/cloud/runtime/client"
 	cmanager "sigs.k8s.io/cluster-api/test/infrastructure/inmemory/internal/cloud/runtime/manager"
 )
@@ -37,7 +36,4 @@ type Manager cmanager.Manager
 var (
 	// NewManager returns a new Manager for creating Controllers.
 	NewManager = cmanager.New
-
-	// NewControllerManagedBy returns a new controller builder that will be started by the provided Manager.
-	NewControllerManagedBy = cbuilder.ControllerManagedBy
 )
diff --git a/test/infrastructure/inmemory/internal/cloud/doc.go b/test/infrastructure/inmemory/internal/cloud/doc.go
@@ -27,7 +27,6 @@ We can't use controller-runtime directly for the following reasons:
 * data should be stored in-memory
 * we would like that objects in memory behave like Kubernetes objects (garbage collection)
 
-The Manager, is the object responsible for the lifecycle of objects; it also allows
-defining controllers.
+The Manager, is the object responsible for the lifecycle of objects.
 */
 package cloud
diff --git a/test/infrastructure/inmemory/internal/cloud/runtime/builder/builder.go b/test/infrastructure/inmemory/internal/cloud/runtime/builder/builder.go
diff --git a/test/infrastructure/inmemory/internal/cloud/runtime/builder/doc.go b/test/infrastructure/inmemory/internal/cloud/runtime/builder/doc.go
diff --git a/test/infrastructure/inmemory/internal/cloud/runtime/builder/options.go b/test/infrastructure/inmemory/internal/cloud/runtime/builder/options.go
diff --git a/test/infrastructure/inmemory/internal/cloud/runtime/cache/cache.go b/test/infrastructure/inmemory/internal/cloud/runtime/cache/cache.go
@@ -35,7 +35,6 @@ import (
 )
 
 // Cache implements an in-memory cache.
-// TODO: consider if to move to internal.
 type Cache interface {
 	Start(ctx context.Context) error
 

diff --git a/test/infrastructure/inmemory/internal/cloud/runtime/cache/cache_test.go b/test/infrastructure/inmemory/internal/cloud/runtime/cache/cache_test.go
@@ -43,7 +43,7 @@ func init() {
 }
 
 func Test_cache_scale(t *testing.T) {
-	t.Skip()
+
 	g := NewWithT(t)
 
 	ctrl.SetLogger(klog.Background())

diff --git a/test/infrastructure/inmemory/internal/cloud/runtime/cache/doc.go b/test/infrastructure/inmemory/internal/cloud/runtime/cache/doc.go
@@ -18,10 +18,8 @@ limitations under the License.
 Package cache defines resource group aware Cache.
 
 The Cache implements sync loop and garbage collector inspired from the ones existing
-in Kubernetes, but in this case only finalizers are respected while currently there is not
-a concept of ownerReferences.
+in Kubernetes.
 
-Note: The cloud runtime is using a Cache for all the resource groups, so it will be possible
-to implement controllers processing request from all the resources groups.
+Note: The cloud runtime is using a Cache for all the resource groups.
 */
 package cache