Apply suggestions from code review

Co-authored-by: Vince Prignano <vince@prigna.com>
kubernetes-sigs · Jan 15, 2024 · 563213a · 563213a
1 parent 6fa9f49
commit 563213a
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go b/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go
@@ -350,9 +350,8 @@ func (r *KubeadmConfigReconciler) refreshBootstrapTokenIfNeeded(ctx context.Cont
 	// Extend TTL for existing token
 	newExpiration := time.Now().UTC().Add(r.TokenTTL).Format(time.RFC3339)
 	secret.Data[bootstrapapi.BootstrapTokenExpirationKey] = []byte(newExpiration)
-	log.Info("Refreshing token until the infrastructure has a chance to consume it", "oldExpiration", secretExpiration, "newExpiration", newExpiration)
-	err = remoteClient.Update(ctx, secret)
-	if err != nil {
+	log.Info("Bootstrap data hasn't yet been consumed by an infrastructure provider; refreshing token", "oldExpiration", secretExpiration, "newExpiration", newExpiration)
+	if err := remoteClient.Update(ctx, secret); err != nil {
 		return ctrl.Result{}, errors.Wrapf(err, "failed to refresh bootstrap token")
 	}
 	return ctrl.Result{