Skip to content

Commit

Permalink
Merge pull request #1411 from tahsinrahman/secret-ownerref
Browse files Browse the repository at this point in the history
⚠️ Remove the Secret's OwnerReferences before pivot
  • Loading branch information
k8s-ci-robot committed Sep 12, 2019
2 parents a15c012 + 18a5daa commit 5cd7261
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions cmd/clusterctl/phases/pivot.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,10 @@ func moveSecret(from sourceClient, to targetClient, secret *corev1.Secret) error
// New objects cannot have a specified resource version. Clear it out.
secret.SetResourceVersion("")

// Remove owner reference.
secret.SetOwnerReferences(nil)
// remove the UID from ownerReferences as it will be different across clusters
for i := 0; i < len(secret.OwnerReferences); i++ {
secret.OwnerReferences[i].UID = ""
}

if err := to.CreateSecret(secret); err != nil {
return errors.Wrapf(err, "error copying Secret %s/%s to target cluster", secret.Namespace, secret.Name)
Expand Down

0 comments on commit 5cd7261

Please sign in to comment.