Merge pull request #9446 from sbueringer/pr-add-loggercheck

🌱 Add loggercheck linter and fix findings
kubernetes-sigs · Sep 18, 2023 · 90537d1 · 90537d1
2 parents 0333e94 + 55b983e
commit 90537d1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -36,6 +36,7 @@ linters:
   - govet
   - importas
   - ineffassign
+  - loggercheck
   - misspell
   - nakedret
   - nilerr

diff --git a/internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go b/internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go
@@ -106,7 +106,7 @@ func (r *Reconciler) reconcileOldMachineSetsOnDelete(ctx context.Context, oldMSs
 		}
 		selectorMap, err := metav1.LabelSelectorAsMap(&oldMS.Spec.Selector)
 		if err != nil {
-			log.V(4).Error(err, "failed to convert MachineSet %q label selector to a map", oldMS.Name)
+			log.V(4).Error(err, "failed to convert MachineSet label selector to a map")
 			continue
 		}
 		log.V(4).Info("Fetching Machines associated with MachineSet")

diff --git a/test/infrastructure/docker/internal/docker/manager.go b/test/infrastructure/docker/internal/docker/manager.go
@@ -172,7 +172,7 @@ func createNode(ctx context.Context, opts *nodeCreateOpts) (*types.Node, error)
 		}
 	}
 
-	log.V(6).Info("Container run options: %+v", runOptions)
+	log.V(6).Info(fmt.Sprintf("Container run options: %+v", runOptions))
 
 	containerRuntime, err := container.RuntimeFrom(ctx)
 	if err != nil {