Skip to content

Commit

Permalink
Merge pull request #7662 from killianmuldoon/fix-comment
Browse files Browse the repository at this point in the history
🐛 Remove inaccurate comment on KCP test
  • Loading branch information
k8s-ci-robot committed Nov 30, 2022
2 parents 709d848 + 3d68806 commit 9702ce5
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions controlplane/kubeadm/internal/controllers/controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -824,9 +824,6 @@ func TestKubeadmControlPlaneReconciler_ensureOwnerReferences(t *testing.T) {

t.Run("replace non-KCP controller with KCP controller reference", func(t *testing.T) {
objs := []client.Object{fakeGenericMachineTemplateCRD, cluster.DeepCopy(), kcp.DeepCopy(), tmpl.DeepCopy()}
// A simulacrum of the various Certificate and kubeconfig secrets
// it's a little weird that this is one per KubeadmConfig rather than just whichever config was "first,"
// but the intent is to ensure that the owner is changed regardless of which Machine we start with
for _, purpose := range []secret.Purpose{secret.ClusterCA, secret.FrontProxyCA, secret.ServiceAccount, secret.EtcdCA} {
s := clusterSecret.DeepCopy()
// Set the secret name to the purpose
Expand Down

0 comments on commit 9702ce5

Please sign in to comment.