Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Generate weekly PR updates to post in Slack docs/process #10008

Closed
cahillsf opened this issue Jan 15, 2024 · 4 comments · Fixed by #10092
Closed

Improve Generate weekly PR updates to post in Slack docs/process #10008

cahillsf opened this issue Jan 15, 2024 · 4 comments · Fixed by #10092
Assignees
Labels
area/release Issues or PRs related to releasing needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@cahillsf
Copy link
Member

cahillsf commented Jan 15, 2024

Currently the release documentation for Generate weekly PR updates to post in Slack and help from the tool does not specify what the milestone option should correspond to

Based on the current behavior, the milestone should correspond to the branch the user has checked out if working off a previous release branch or the upcoming milestone if generating from main, because we are using the command: git rev-list HEAD to retrieve the commits.

Since HEAD refers to the currently checked-out branch's latest commit, it is either:

  • retrieving all of the commits that have been cherry-picked to a previous release's branch (will correspond to that specific release milestone)
  • retrieving all of the commits to main (will correspond to upcoming release milestone)

Currently the tool just uses the milestone to generate the link, but does not incorporate it when retrieving the commits, which has led to some inaccurate use of the tool

To improve this situation, we should do one or more of the following:

  • update the documentation/help text to specify how the milestone option should be used
  • improve the tool to work off 1 input to retrieve the commits and generate the milestone

/area release

@k8s-ci-robot k8s-ci-robot added the area/release Issues or PRs related to releasing label Jan 15, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 15, 2024
@cahillsf
Copy link
Member Author

see this issue for context: #9918 (comment)

if takes this issue, they should be sure to solve for this as well, but the scope for the current issue is smaller and could be a quicker short term change

@typeid
Copy link
Contributor

typeid commented Jan 31, 2024

/assign

@typeid
Copy link
Contributor

typeid commented Feb 2, 2024

I have tried addressing this in #10092. Let me know what you think! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release Issues or PRs related to releasing needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants