-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Improve weekly PR update generation script and documentation #10092
Conversation
Hi @typeid. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This will be a great improvement to the current tool 🚀
0c4dc86
to
710889d
Compare
I'm not fully sure why the lint workflow fails. |
4d6fea6
to
b973c82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Great work!!
LGTM label has been added. Git tree hash: 1bf8e39c2418e59c115a73c266c1e79ff9755e06
|
docs/release/release-tasks.md
Outdated
```bash | ||
./bin/weekly --from YYYY-MM-DD --to YYYY-MM-DD --milestone v1.x | ||
./bin/weekly --since YYYY-MM-DD --until YYYY-MM-DD --branch release-1.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this generic example is in conflict with the provided examples, specifically the --branch
arg: ./bin/weekly --since 2024-01-22 --until 2024-01-28 --branch main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be more generic now, thanks for pointing that out Stephen.
would you mind pushing a small update to this line too: cluster-api/hack/tools/release/weekly/main.go Line 193 in b973c82
i think the underscores should be |
/retest |
/lgtm |
LGTM label has been added. Git tree hash: 3d33eb8f1231778c4c4cdc1f89815116b9abfe42
|
very nice! thanks for this update 👍 /lgtm |
/approve (given lgtm's above. I didn't review the code change) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Currently, the usage of the weekly PR update generation script is a bit confusing because it requires checking out the right branches as well as providing the right milestones for these branches. This PR attempts to address this issue by clarifying the documentation and updating the script to only use the branch parameter for the whole flow.
This PR updates the
Generate weekly PR updates to post in Slack
flow:--milestone
is now--branch
and should no more cause confusion between the relationship of branch to milestone--branch
was addedWhich issue(s) this PR fixes
Fixes #10008
/area release