Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick start provider tabs lead to the wrong providers #10098

Closed
stmcginnis opened this issue Feb 5, 2024 · 6 comments · Fixed by #10099
Closed

Quick start provider tabs lead to the wrong providers #10098

stmcginnis opened this issue Feb 5, 2024 · 6 comments · Fixed by #10099
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@stmcginnis
Copy link
Contributor

stmcginnis commented Feb 5, 2024

What steps did you take and what happened?

In the quick start guide there are a couple places where there are provider-specific steps required. This is handled by having a set of tabs, one for each provider, that gives the relevant information for the desired provider.

The current quick start doc provider tabs are displaying the incorrect provider information. Tab content is off by one due to the addition of a k0smotron provider tab (#9991) content panel without a corresponding selection tab.

What did you expect to happen?

Selecting a tab such as proxmox should display the proxmox information.

Cluster API version

NA

Kubernetes version

NA

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 5, 2024
@stmcginnis
Copy link
Contributor Author

/assign

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 5, 2024
@richardcase
Copy link
Member

I ran into this with when trying to install the kubevirt provider.

@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 5, 2024
@niklas-letz
Copy link

This issue seems to be still present although the missing tab title for k0smotron was added already (PR #10099).
I can see that the tab content is still off by one and the k0smotron tab is missing.

@chrischdi
Copy link
Member

This issue seems to be still present although the missing tab title for k0smotron was added already (PR #10099). I can see that the tab content is still off by one and the k0smotron tab is missing.

I opened the following PR to fix it:

@chrischdi
Copy link
Member

Quickstart doc should now be good again. Thanks @niklas-letz for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants