Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add provider tab for k0smotron #10099

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

stmcginnis
Copy link
Contributor

@stmcginnis stmcginnis commented Feb 5, 2024

What this PR does / why we need it:

Tab content was added to the quick start guide for k0smotron, but the tab heading was missed. This results in selecting anything after the IBM provider tab displaying the incorrect provider information.

This adds the tab title so the tabs and their contents match up correctly.

Which issue(s) this PR fixes:

Fixes #10098

/area documentation

Tab content was added to the quick start guide for k0smotron, but
the tab heading was missed. This results in selecting anything after
the IBM provider tab displaying the incorrect provider information.

This adds the tab title so the tabs and their contents match up
correctly.

Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2024
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for fixing this!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c7ac330d24ed3ddc82b62cb6ff89a9d4a1b6328

@k8s-ci-robot k8s-ci-robot merged commit ad9151c into kubernetes-sigs:main Feb 5, 2024
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Feb 5, 2024
@chrischdi
Copy link
Member

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot

@chrischdi: #10099 failed to apply on top of branch "release-1.6":

Applying: Add provider tab for k0smotron
Using index info to reconstruct a base tree...
M	docs/book/src/user/quick-start.md
Falling back to patching base and 3-way merge...
Auto-merging docs/book/src/user/quick-start.md
CONFLICT (content): Merge conflict in docs/book/src/user/quick-start.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add provider tab for k0smotron
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick start provider tabs lead to the wrong providers
5 participants