make target generate-manifests panics when using go version 1.22 #10240
Labels
kind/bug
Categorizes issue or PR as related to a bug.
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Comments
|
This issue is currently awaiting triage. CAPI contributors will take a look as soon as possible, apply one of the Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-triage
|
Maybe worth opening an issue for Controller-tools? Also could be that this needs go.work?! (they recently merged go.work in k/k) |
|
Note: not reproducible for me on latest main ( ❯ go version
go version go1.22.0 darwin/arm64
❯ make generate-manifests
/Library/Developer/CommandLineTools/usr/bin/make clean-generated-yaml SRC_DIRS="./config/crd/bases,./config/webhook/manifests.yaml"
(IFS=','; for i in ./config/crd/bases,./config/webhook/manifests.yaml; do find $i -type f -name '*.yaml' -exec rm -f {} \;; done)
/Users/schlotterc/go/src/sigs.k8s.io/cluster-api/hack/tools/bin/controller-gen-v0.14.0 \
paths=./ \
paths=./api/... \
paths=./internal/apis/core/... \
paths=./internal/controllers/... \
paths=./internal/webhooks/... \
paths=./exp/api/... \
paths=./exp/internal/controllers/... \
paths=./exp/internal/webhooks/... \
paths=./exp/addons/api/... \
paths=./exp/addons/internal/controllers/... \
paths=./exp/addons/internal/webhooks/... \
paths=./exp/ipam/api/... \
paths=./exp/ipam/internal/webhooks/... \
paths=./exp/runtime/api/... \
paths=./exp/runtime/internal/controllers/... \
crd:crdVersions=v1 \
rbac:roleName=manager-role \
output:crd:dir=./config/crd/bases \
output:webhook:dir=./config/webhook \
webhook
... |
|
xref: @elmiko seems to be fixed with controller-gen v0.14.0 which is already merged on main :-) |
|
/priority important-soon @elmiko could you kindly check this again? |
k8s-ci-robot
added
the
priority/important-soon
|
using go version 1.22.1, looks like |
|
Thx! I'm aware of a few more reports of controller-gen <= 0.13 being incompatible with Go 1.22. So I think it all makes sense and we can close this issue /close |
|
@sbueringer: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps did you take and what happened?
make generate-manifestsfrom the new repocommand panics with this output:
What did you expect to happen?
manifests to be generated properly
Cluster API version
tested on v1.6.2 and main
Kubernetes version
n/a
Anything else you would like to add?
downgrading to go version 1.21.3 fixes the issue
Label(s) to be applied
/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
The text was updated successfully, but these errors were encountered: