Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clusterctl should remove the Secret's OwnerReferences before pivot #1404

Closed
vincepri opened this issue Sep 9, 2019 · 2 comments · Fixed by #1411
Closed

Clusterctl should remove the Secret's OwnerReferences before pivot #1404

vincepri opened this issue Sep 9, 2019 · 2 comments · Fixed by #1411
Assignees
@tahsinrahman
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.2.x

Comments

@vincepri
Copy link
Member

vincepri commented Sep 9, 2019

/kind feature

Describe the solution you'd like
We should remove OwnerReferences from Secrets upon pivot if (and only if) they are part of our known APIGroups.

/help
/priority important-soon
@vincepri vincepri added this to the v0.2.x (v1alpha2) milestone Sep 9, 2019
@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/kind feature

Describe the solution you'd like
We should remove OwnerReferences from Secrets upon pivot if (and only if) they are part of our known APIGroups.

/help
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 9, 2019
@tahsinrahman
Copy link
Contributor

/assign

@tahsinrahman tahsinrahman mentioned this issue Sep 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tahsinrahman tahsinrahman

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.2.x
Development

Successfully merging a pull request may close this issue.

⚠️ Remove the Secret's OwnerReferences before pivot tahsinrahman/cluster-api
3 participants
@vincepri @tahsinrahman @k8s-ci-robot