Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify go modules in CI #1419

Closed
vincepri opened this issue Sep 12, 2019 · 7 comments · Fixed by #1443
Closed

Verify go modules in CI #1419

vincepri opened this issue Sep 12, 2019 · 7 comments · Fixed by #1443
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone

Comments

@vincepri
Copy link
Member

/kind feature

Describe the solution you'd like
As part of our make verify target, we should add another scripts that calls make modules and checks if there are any changes.

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/kind feature

Describe the solution you'd like
As part of our make verify target, we should add another scripts that calls make modules and checks if there are any changes.

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 12, 2019
@vincepri vincepri added this to the v0.2.x milestone Sep 12, 2019
@pjot726
Copy link

pjot726 commented Sep 12, 2019

Can I start working on this, or do I need to be assigned the issue?

@detiber
Copy link
Member

detiber commented Sep 12, 2019

@pjot726 no one is currently assigned or working on it currently, so feel free to take it.
/assign @pjot726
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Sep 12, 2019
@ncdc
Copy link
Contributor

ncdc commented Sep 25, 2019

We recently merged kubernetes-sigs/cluster-api-provider-aws#1131 for CAPA - @pjot726 if you're still interested, could you copy that over to here?

@ncdc
Copy link
Contributor

ncdc commented Sep 25, 2019

Or please let us know if you won't have time to work on this.

@pjot726
Copy link

pjot726 commented Sep 25, 2019

@ncdc I don't think I'll be able to work on this for a while, sorry. Feel free to reassign the issue.

@tahsinrahman
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants