Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeadmControlPlane does not apply labels to control plane machines correctly #2081

Closed
chuckha opened this issue Jan 16, 2020 · 2 comments
Closed
Assignees
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone

Comments

@chuckha
Copy link
Contributor

chuckha commented Jan 16, 2020

What steps did you take and what happened:
I'm verifying right now but wanted to write this down in case I don't finish verifying today.

I do not think the KCP controller applies the correct label to control plane machines vs worker machines.

/kind bug

/assign
/lifecycle active
/milestone v0.3.0

related to #1756

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Jan 16, 2020
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 16, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Jan 16, 2020

/close

This is incorrect right but I found a different, potential bug, will file a follow up issue

@k8s-ci-robot
Copy link
Contributor

@chuckha: Closing this issue.

In response to this:

/close

This is incorrect right but I found a different, potential bug, will file a follow up issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri vincepri added the area/control-plane Issues or PRs related to control-plane lifecycle management label Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

No branches or pull requests

3 participants