Should we update Cluster.Status.FailureDomains to ListType=map

[detiber]

If we adopt CRD v1, I'm wondering if we should also update FailureDomains from a map to a ListType=map (as is supported by controller-tools v0.2.5)?

This is a part of the server-side apply work that is being tracked here: kubernetes-sigs/structured-merge-diff#115

[vincepri]

If we update, I'm all +1 for this given that I chose the map specifically because I didn't have guarantees for all the IDs in a list.

[vincepri]

/milestone v0.3.0
/priority backlog

[vincepri]

Blocked on CRDv1 update

[detiber]

@vincepri is this something we should now look at for the v0.3.0-rc.0 milestone?

My main concern here is that since we are introducing the type this upcoming release, if there is a chance we are going to want to change it we should do it before the release rather than after to avoid having to deal with a conversion issue down the line.

[vincepri]

If someone can pick it up tomorrow, we can definitely add it to the RC. That said, it's fine to break things between RCs.

[detiber]

I'm not concerned as much with the RC.

/priority important-soon

[vincepri]

/milestone Next

Moving this out of the milestone due to timing and required API/code changes in CAPI and infrastructure providers

[vincepri]

/area api

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[vincepri]

/lifecycle frozen

[vincepri]

Yes, we should probably investigate this once we have better support for server side apply

[vincepri]

@detiber Server side apply support from controller runtime is still lacking, pushing this back a bit.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.