Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clusterctl cert-manager timeout configurable #2822

Closed
ncdc opened this issue Mar 30, 2020 · 9 comments · Fixed by #2834
Closed

Make clusterctl cert-manager timeout configurable #2822

ncdc opened this issue Mar 30, 2020 · 9 comments · Fixed by #2834
Assignees
Labels
area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@ncdc
Copy link
Contributor

ncdc commented Mar 30, 2020

User Story

As a developer using the clusterctl library, I would like to be able to specify a custom timeout for waiting for cert-manager to be available, as the default hard-coded 10 minute value might not be enough if my internet connection is slow.

As a user using clusterctl, I would like to be able to specify a custom timeout for waiting for cert-manager to be available, as the default hard-coded 10 minute value might not be enough if my internet connection is slow.

Detailed Description

See user story

Anything else you would like to add:

N/A

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 30, 2020
@ncdc ncdc added area/clusterctl Issues or PRs related to clusterctl and removed kind/feature Categorizes issue or PR as related to a new feature. labels Mar 30, 2020
@vincepri
Copy link
Member

/help
/milestone v0.3.4

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/milestone v0.3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.3.4 milestone Mar 30, 2020
@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 30, 2020
@vincepri
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 30, 2020
@vincepri
Copy link
Member

@fabriziopandini How do we set other timeouts today? Environment variables, flags?

@ncdc
Copy link
Contributor Author

ncdc commented Mar 30, 2020

MVP for me is library-only for an API consumer. Bonus is a flag or env var.

@nader-ziada
Copy link
Contributor

/assign

@fabriziopandini
Copy link
Member

The simplest implementation will be using envvars, like e.g we are doing for the overrideFolder.
Library only requires an interface change, soI highly raccomand to tackle this with #2597 and #2659

@nader-ziada
Copy link
Contributor

@fabriziopandini I was trying to implement this by adding a flag to the init command, do you think that is better or doing a env var?

@ncdc
Copy link
Contributor Author

ncdc commented Mar 30, 2020

Ok, env var is fine for now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants