Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set User Agent and Request Timeout for Remote Cluster Caches #2993

Closed
JoelSpeed opened this issue May 1, 2020 · 12 comments · Fixed by #4060
Closed

Set User Agent and Request Timeout for Remote Cluster Caches #2993

JoelSpeed opened this issue May 1, 2020 · 12 comments · Fixed by #4060
Assignees
@nader-ziada @yindia
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.4

Comments

@JoelSpeed
Copy link
Contributor

User Story

We should set a user agent on the clients used by the remote cluster caches introduced in #2880 so that request logs can be tracked back to the cluster caches.

We should also set a Timeout on the requests so that failed connections time out rather than hanging

(Originally suggested by @fabriziopandini and @ncdc)

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 1, 2020
@vincepri
Copy link
Member

vincepri commented May 1, 2020

/milestone v0.3.x
/help
/priority important-longterm

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/milestone v0.3.x
/help
/priority important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone May 1, 2020
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 1, 2020
This was referenced Jun 10, 2020
Closed
Merged
@spagno
Copy link
Contributor

spagno commented Jun 15, 2020

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jun 15, 2020
@vincepri vincepri removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Aug 3, 2020
@vincepri
Copy link
Member

vincepri commented Aug 3, 2020

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.3.x, v0.4.0 Aug 3, 2020
@yindia
Copy link

yindia commented Sep 30, 2020

/assign @evalsocket

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2020
@fabriziopandini
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2020
@detiber
Copy link
Member

detiber commented Jan 5, 2021

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 5, 2021
@vincepri
Copy link
Member

vincepri commented Jan 5, 2021

/assign @nader-ziada

@nader-ziada
Copy link
Contributor

/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Jan 6, 2021
@nader-ziada
Copy link
Contributor

I think I need a little bit more context, can't find any previous conversations about this, is it just adding the user agent and timeout to the remote cluster client?

@fabriziopandini
Copy link
Member

Yes, it is just that.
The user agent can be helpful when auditing API server calls
The timeout helps to avoid being blocked (by default the client waits forever)

@nader-ziada nader-ziada mentioned this issue Jan 8, 2021
Merged
@killianmuldoon killianmuldoon mentioned this issue Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nader-ziada nader-ziada

@yindia yindia

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

⚠️ Set user agent and timeout for remote cluster client nader-ziada/cluster-api
9 participants
@detiber @vincepri @fabriziopandini @spagno @nader-ziada @JoelSpeed @yindia @k8s-ci-robot @fejta-bot