Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new a live client where we don't need caching #3892

Closed
ncdc opened this issue Nov 2, 2020 · 5 comments · Fixed by #4023
Closed

Use new a live client where we don't need caching #3892

ncdc opened this issue Nov 2, 2020 · 5 comments · Fixed by #4023
Assignees
@vincepri
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.4

Comments

@ncdc
Copy link
Contributor

ncdc commented Nov 2, 2020

Use #3891's new live client to manipulate ConfigMaps and Secrets where we don't need caching:

  • KCP - CoreDNS CoreFile ConfigMap
  • KCP - kubelet ConfigMap
  • KCP - kubeadm ConfigMap
  • CAPBK - refreshing the bootstrap token
  • CAPBK - spec.files secret refs
  • The helpers that get the kubeconfig secret
  • The helpers that work with certificate secrets
  • ClusterResourceSet (will need the metadata-only watches support - Backport #1174 metadata-only watches to 0.5 controller-runtime#1237)
@ncdc
Copy link
Contributor Author

ncdc commented Nov 2, 2020

cc @akutz

@vincepri
Copy link
Member

vincepri commented Nov 2, 2020

/assign

@vincepri
Copy link
Member

vincepri commented Nov 2, 2020

KCP seems it's already using an uncached client internally. The client gets created when getting a workload cluster. The tracker's cached client isn't used anywhere apparently.

@vincepri vincepri changed the title Use new ClusterCacheTracker's live client where we don't need caching Use new a live client where we don't need caching Nov 3, 2020
@vincepri
Copy link
Member

vincepri commented Nov 3, 2020

/milestone v0.4.0

Renamed because some of these don't need to use the workload cluster, but instead use a normal API Reader

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Nov 3, 2020
@vincepri vincepri mentioned this issue Nov 3, 2020
Closed
@vincepri
Copy link
Member

vincepri commented Dec 3, 2020

I'm going to open two different PRs for v0.4.0 and v0.3.12 given that there is lots of different separate changes (due to controller runtime versions)

@vincepri vincepri mentioned this issue Dec 3, 2020
Merged
@fabriziopandini fabriziopandini added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 10, 2020
@vincepri vincepri mentioned this issue Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincepri vincepri

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

✨ Use uncached client and partial metadata for secret and configmaps vincepri/cluster-api
4 participants
@ncdc @vincepri @fabriziopandini @k8s-ci-robot