Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve help text for 'kubeconfig', 'namespace', and 'cluster' in client-go #397

Closed
spew opened this issue Jun 25, 2018 · 2 comments
Closed
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@spew
Copy link
Contributor

spew commented Jun 25, 2018

In PR #384 it was noted that the help text for the three parameters, 'kubeconfig', 'namespace', and 'cluster', was not very helpful. This text comes from the client-go libraries that are used by kubectl and clusterctl. This issue tracks that we need to open a PR on client-go to improve that text.

@timothysc timothysc added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 11, 2019
@timothysc timothysc added this to the v1alpha1 milestone Jan 11, 2019
@roberthbailey
Copy link
Contributor

I went back and looked at my original comment that spawned this issue. Looking at our current help text it's changed quite a bit and now doesn't have the readability problems I was complaining about.

It looks like it was fixed even before the migration to kubebuilder and it isn't worth digging back further to see who fixed this or when. Either way, it's now obsolete.

/close

@k8s-ci-robot
Copy link
Contributor

@roberthbailey: Closing this issue.

In response to this:

I went back and looked at my original comment that spawned this issue. Looking at our current help text it's changed quite a bit and now doesn't have the readability problems I was complaining about.

It looks like it was fixed even before the migration to kubebuilder and it isn't worth digging back further to see who fixed this or when. Either way, it's now obsolete.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants