Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate usage of "gcr.io/kubernetes-ci-images" #4103

Closed
neolit123 opened this issue Jan 21, 2021 · 7 comments · Fixed by #4107
Closed

migrate usage of "gcr.io/kubernetes-ci-images" #4103

neolit123 opened this issue Jan 21, 2021 · 7 comments · Fixed by #4107
Assignees
@fmuyassarov
Labels
area/testing Issues or PRs related to testing good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@neolit123
Copy link
Member

neolit123 commented Jan 21, 2021 •
edited

Detailed Description

as part of migrating the k8s google infra to community maintained the GCR bucket "gcr.io/kubernetes-ci-images"
is being renamed to "gcr.io/k8s-staging-ci-images".
kubernetes/k8s.io#1460

we already applied this change to kubeadm, but a search revealed that CAPI has it in a few places, including :

  • kubeadm forked types
  • CRDs
  • test framework

/kind feature
/priority important-soon
(this change will happen in the 1.21 cycle)
/help
if someone wants to help with the cleanup.
@k8s-ci-robot
Copy link
Contributor

@neolit123:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Detailed Description

as part of migrating the k8s google infra to community maintained the GCR bucket "gcr.io/kubernetes-ci-images"
is being renamed to "gcr.io/k8s-staging-ci-images".

we already applied this change to kubeadm, but a search revealed that CAPI has it in a few places:

  • including kubeadm forked types
  • CRDs
  • test framework

/kind feature
/priority important-soon
(this change will happen in the 1.21 cycle)
/help
if someone wants to help with the cleanup.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 21, 2021
@fabriziopandini
Copy link
Member

/good-first-issue
/area testing

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/area testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jan 21, 2021
@fabriziopandini
Copy link
Member

On top of
gcr.io/kubernetes-ci-images --> gcr.io/k8s-staging-ci-images

I suggest changing also
https://storage.googleapis.com/kubernetes-release-dev --> https://storage.googleapis.com/k8s-release-dev

in the same PR (or in separate PR if you prefer)

@neolit123 neolit123 mentioned this issue Jan 21, 2021
Closed
@fmuyassarov
Copy link
Member

Hi @fabriziopandini. Can I work on this ?

@fmuyassarov
Copy link
Member

/assign

@fmuyassarov fmuyassarov mentioned this issue Jan 22, 2021
Merged
@neolit123
Copy link
Member Author

I suggest changing also
https://storage.googleapis.com/kubernetes-release-dev --> https://storage.googleapis.com/k8s-release-dev

looks like the new GCS bucket doesn't have the latest artifacts:
kubernetes/kubeadm#2380 (comment)
kubernetes/k8s.io#1460 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmuyassarov fmuyassarov

Labels
area/testing Issues or PRs related to testing good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Migrate gcr.io/kubernetes-ci-images to gcr.io/k8s-staging-ci-images Nordix/cluster-api
4 participants
@neolit123 @fabriziopandini @k8s-ci-robot @fmuyassarov