-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ProviderConfig to ProviderSpec #414
Comments
I think my rationale may be specious. configuration := an arrangement of elements in a particular form, figure, or combination. Since there is a ¯_(ツ)_/¯ |
Working on a PR for this |
I'm waiting for the move to CRDs before working on this change. |
Thanks. :) |
Rename API group to "vsphere.cluster.k8s.io"
From what I understand, the name
ProviderConfig
was chosen because it is "a serialized API object in a format owned by that provider, akin to the Component Config pattern" (emphasis mine). [0]Unlike a Component Config, a
ProviderConfig
has a correspondingProviderStatus.
The nameProviderSpec
follows from the Kubernetes API Status/Spec convention.[0] https://github.com/kubernetes/community/blob/master/keps/sig-cluster-lifecycle/0003-cluster-api.md#overview
The text was updated successfully, but these errors were encountered: