Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ProviderConfig to ProviderSpec #414

Closed
dlipovetsky opened this issue Jul 2, 2018 · 4 comments · Fixed by #548
Closed

Change ProviderConfig to ProviderSpec #414

dlipovetsky opened this issue Jul 2, 2018 · 4 comments · Fixed by #548

Comments

@dlipovetsky
Copy link
Contributor

From what I understand, the name ProviderConfig was chosen because it is "a serialized API object in a format owned by that provider, akin to the Component Config pattern" (emphasis mine). [0]

Unlike a Component Config, a ProviderConfig has a corresponding ProviderStatus. The name ProviderSpec follows from the Kubernetes API Status/Spec convention.

[0] https://github.com/kubernetes/community/blob/master/keps/sig-cluster-lifecycle/0003-cluster-api.md#overview

@davidewatson
Copy link
Contributor

davidewatson commented Jul 4, 2018

I think my rationale may be specious.

configuration := an arrangement of elements in a particular form, figure, or combination.
specification := an act of describing or identifying something precisely or of stating a precise requirement.

Since there is a ProviderStatus it seems reasonable to make the design pattern explicit by having a corresponding ProviderSpec.

¯_(ツ)_/¯

@dlipovetsky
Copy link
Contributor Author

Working on a PR for this

@dlipovetsky
Copy link
Contributor Author

I'm waiting for the move to CRDs before working on this change.

@roberthbailey
Copy link
Contributor

Thanks. :)

jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
Rename API group to "vsphere.cluster.k8s.io"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants