Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure kubeadm 1.24 socket auto-discovery doesn't lead to issues #5920

Closed
Tracked by #5968
sbueringer opened this issue Jan 10, 2022 · 5 comments
Closed
Tracked by #5968
Labels
area/bootstrap Issues or PRs related to bootstrap providers kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@sbueringer
Copy link
Member

sbueringer commented Jan 10, 2022

With kubeadm 1.24 there are some changes related to the removal of the dockershim (see Mail, kubeadm Issue).

The only relevant change for us should be:

  • always error out if multiple CRI compatible sockets are found on the
    host and ask the user to specify which one to use. do not special case
    containerd+docker if both sockets are present.

This shouldn't be an issue in our e2e tests as we always set the criSocket and it probably also shouldn't be an issue with image-builder (I'm not sure if docker is installed there and even if it is if that means that both sockets are there).

But let's keep this issue around until 1.24 to spread the word and see if we get errors in CI (if we get them, probably in infra providers).

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 10, 2022
@sbueringer
Copy link
Member Author

/area bootstrap

@k8s-ci-robot k8s-ci-robot added the area/bootstrap Issues or PRs related to bootstrap providers label Jan 10, 2022
@fabriziopandini
Copy link
Member

/milestone v1.2

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jan 26, 2022
@sbueringer
Copy link
Member Author

sbueringer commented Feb 11, 2022

I created a CAPA cluster with Kubernetes v1.22 and there only the containerd.socket exists.

Corresponding code in kubeadm is:

So I would assume we should be fine as it seems that image-builder is just installing containerd and we can close this issue.

cc @yastij for awareness (and objections :) )

@sbueringer
Copy link
Member Author

Closing for now, if we have concrete issues/concerns, feel free to reopen

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

Closing for now, if we have concrete issues/concerns, feel free to reopen

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Issues or PRs related to bootstrap providers kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants