Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to CoreDNS bump to 1.9.3 #6641

Closed
fabriziopandini opened this issue Jun 13, 2022 · 17 comments · Fixed by kubernetes/test-infra#26629
Closed

Align to CoreDNS bump to 1.9.3 #6641

fabriziopandini opened this issue Jun 13, 2022 · 17 comments · Fixed by kubernetes/test-infra#26629
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@fabriziopandini
Copy link
Member

CAPI should align its tests to CoreDNS bump to 1.9.3 in kubeadm, rif kubernetes/kubernetes#110489

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 13, 2022
@fabriziopandini
Copy link
Member Author

note, the PR contains also a bump to github.com/coredns/corefile-migration v1.0.17

@sbueringer
Copy link
Member

Migration lib is up to date in CAPI

@sbueringer
Copy link
Member

Just for folks who are not familiar with how we align to something like that.

We usually (if supported by CAPI) use the CoreDNS version used by the respective kubeadm version.

I.e. if we have an upgrade from v1.24=>v1.25, We create the cluster with kubeadm init (v1.24) and then upgrade to v1.25 so we use the CoreDNS version of kubeadm 1.25 as COREDNS_VERSION_UPGRADE_TO.

This means that aligning to v1.9.3 means that we should change COREDNS_VERSION_UPGRADE_TO to v1.9.3 in jobs where we upgrade to v1.25

@chrischdi
Copy link
Member

/assign

@sbueringer
Copy link
Member

Please note there's a PR open to add the 1.2 jobs: kubernetes/test-infra#26621

We have to make sure that they eventually also use the right CoreDNS version

@sbueringer
Copy link
Member

(doesn't block this issue, we should just make sure to comment on the 1.2 PR to make the same adjustments)

@sbueringer
Copy link
Member

Almost forgot. There is currently no way to verify that a bump to v1.9.3 works in the v1.24=>v1.25 job as this job is currently broken: #6596

@chrischdi
Copy link
Member

Almost forgot. There is currently no way to verify that a bump to v1.9.3 works in the v1.24=>v1.25 job as this job is currently broken: #6596

@sbueringer should I still go forward and already create the PR in tets-infra or should we wait on this until #6596 got fixed?

@sbueringer
Copy link
Member

You can open the pr already if you want

@sbueringer
Copy link
Member

/reopen

Let's keep it open until #6596 is fixed and we can verify everything works

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Reopened this issue.

In response to this:

/reopen

Let's keep it open until #6596 is fixed and we can verify everything works

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jun 20, 2022
@chrischdi
Copy link
Member

@sbueringer I think we can close this one :-) 🎉

@sbueringer
Copy link
Member

My idea was to verify if it actually works after #6596 is fixed. As of today we have a bunch of jobs using 1.9.3 but they are all failing because of #6596.

But yes if you want we can close this issue. We'll notice in #6596 if the new CoreDNS version actually works anyway.

@chrischdi
Copy link
Member

Ah gotcha 👍 thought the 1.22 job was enough, so let's wait until

Is closed.

@sbueringer
Copy link
Member

sbueringer commented Jul 12, 2022

Ah got it :). Only the v1.24=>v1.25 is using it because we align the versions used in e2e tests to the versions hard-coded in kubeadm (and used during kubeadm init)

v1.25 is now using CoreDNS v1.9.3 which triggered this issue

@chrischdi
Copy link
Member

Jobs for CAPI main and v1.2 which upgrade to latest (v1.25) are green 👍 No other tests upgrade to v1.25 and coredns 1.9.3.

/close

@k8s-ci-robot
Copy link
Contributor

@chrischdi: Closing this issue.

In response to this:

Jobs for CAPI main and v1.2 which upgrade to latest (v1.25) are green 👍 No other tests upgrade to v1.25 and coredns 1.9.3.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants