-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align to CoreDNS bump to 1.9.3 #6641
Comments
note, the PR contains also a bump to github.com/coredns/corefile-migration v1.0.17 |
Migration lib is up to date in CAPI |
Just for folks who are not familiar with how we align to something like that. We usually (if supported by CAPI) use the CoreDNS version used by the respective kubeadm version. I.e. if we have an upgrade from v1.24=>v1.25, We create the cluster with kubeadm init (v1.24) and then upgrade to v1.25 so we use the CoreDNS version of kubeadm 1.25 as This means that aligning to v1.9.3 means that we should change |
/assign |
Please note there's a PR open to add the 1.2 jobs: kubernetes/test-infra#26621 We have to make sure that they eventually also use the right CoreDNS version |
(doesn't block this issue, we should just make sure to comment on the 1.2 PR to make the same adjustments) |
Almost forgot. There is currently no way to verify that a bump to v1.9.3 works in the v1.24=>v1.25 job as this job is currently broken: #6596 |
@sbueringer should I still go forward and already create the PR in tets-infra or should we wait on this until #6596 got fixed? |
You can open the pr already if you want |
/reopen Let's keep it open until #6596 is fixed and we can verify everything works |
@sbueringer: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer I think we can close this one :-) 🎉 |
Ah gotcha 👍 thought the 1.22 job was enough, so let's wait until Is closed. |
Ah got it :). Only the v1.24=>v1.25 is using it because we align the versions used in e2e tests to the versions hard-coded in kubeadm (and used during kubeadm init) v1.25 is now using CoreDNS v1.9.3 which triggered this issue |
Jobs for CAPI main and v1.2 which upgrade to latest (v1.25) are green 👍 No other tests upgrade to v1.25 and coredns 1.9.3. /close |
@chrischdi: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CAPI should align its tests to CoreDNS bump to 1.9.3 in kubeadm, rif kubernetes/kubernetes#110489
/kind feature
The text was updated successfully, but these errors were encountered: