Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ImagePullPolicy in KCP and CABPK #6679

Closed
fabriziopandini opened this issue Jun 20, 2022 · 6 comments · Fixed by #7772
Closed

Add support for ImagePullPolicy in KCP and CABPK #6679

fabriziopandini opened this issue Jun 20, 2022 · 6 comments · Fixed by #7772
Assignees
@akshay196
Labels
area/bootstrap Issues or PRs related to bootstrap providers help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

User Story

As a user/operator I would like to use all the latest and greatest from kubeadm

Detailed Description

kubernetes/kubernetes#102901 added support for the imagePullPolicy option in the kubeadm config file; we should make this option available in KCP and CABPK

Anything else you would like to add:

This is a good opportunity to diff the entire set of kubeadm config file options supported in KCP/CABPK and identify other gaps, if any.
Prior art #4905

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 20, 2022
@fabriziopandini fabriziopandini added area/bootstrap Issues or PRs related to bootstrap providers and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jun 20, 2022
@sbueringer sbueringer added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 20, 2022
@sbueringer
Copy link
Member

Just a note. I think we intentionally didn't add some fields because they didn't make sense in our context (I did the diff a few months back)

@fabriziopandini fabriziopandini added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jul 29, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2022
@fabriziopandini
Copy link
Member Author

/lifecycle frozen
/help

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/lifecycle frozen
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 2, 2022
@fabriziopandini
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 30, 2022
@akshay196
Copy link
Contributor

I would like to work on this.
/assign

@akshay196 akshay196 mentioned this issue Dec 17, 2022
Merged
akshay196 added a commit to akshay196/cluster-api that referenced this issue Jan 30, 2023
@akshay196
Add Support for ImagePullPolicy in KCP and CABPK
7ed1548 
Fix kubernetes-sigs#6679

Add the `imagePullPolicy` field in the `nodeRegistration` section of
`InitConfiguration` and `JoinConfiguration`. This allows the user to
specify the image pull policy in KCP and CABPK. The value of this
field must be one of `Always`, `IfNotPresent` or `Never`.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
akshay196 added a commit to akshay196/cluster-api that referenced this issue Jan 30, 2023
@akshay196
Add Support for ImagePullPolicy in KCP and CABPK
7103f32 
Fix kubernetes-sigs#6679

Add the `imagePullPolicy` field in the `nodeRegistration` section of
`InitConfiguration` and `JoinConfiguration`. This allows the user to
specify the image pull policy in KCP and CABPK. The value of this
field must be one of `Always`, `IfNotPresent` or `Never`.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshay196 akshay196

Labels
area/bootstrap Issues or PRs related to bootstrap providers help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Add NodeRegistrationOptions.ImagePullPolicy Support akshay196/cluster-api
5 participants
@sbueringer @fabriziopandini @akshay196 @k8s-ci-robot @k8s-triage-robot