Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Master -> Control Plane #688

Closed
neolit123 opened this issue Jan 16, 2019 · 6 comments · Fixed by #693
Closed

cleanup: Master -> Control Plane #688

neolit123 opened this issue Jan 16, 2019 · 6 comments · Fixed by #693
Assignees
@vincepri
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@neolit123
Copy link
Member

neolit123 commented Jan 16, 2019 •
edited
Loading

this is a request for community members to perform a cleanup on the word "master" in the Cluster API code base and documentation. Possibly send multiple PRs if needed.

As per the Kubernetes Steering committee the word "master" should be omitted as a user exposed term (UX) and instead the term to use should be "control plane".

It might be OK to keep the word "master" in function names and variables that are not API, as this would be hidden from the user, but ideally the change should be applied everywhere.

a github search reveals:
https://github.com/kubernetes-sigs/cluster-api/search?utf8=%E2%9C%93&q=master&type=

/kind cleanup
/help
@k8s-ci-robot
Copy link
Contributor

@neolit123:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

this is a request for community members to perform a cleanup on the word "master" in the Cluster API code base and documentation. Possibly send multiple PRs if needed.

As per the Kubernetes Steering committee the word "master" should be omitted as a user exposed term (UX) and instead the term to use should be "control plane".

It might be OK to keep the word "master" in function names and variables that are not API, as this would be hidden from the user, but ideally the change should be applied everywhere.

/kind cleanup
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 16, 2019
@neolit123
Copy link
Member Author

neolit123 commented Jan 16, 2019 •
edited
Loading

/priority backlog
/good-first-issue

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

@neolit123:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 16, 2019
This was referenced Jan 16, 2019
Merged
Merged
@SupriyaSirbi
Copy link

Could you please assign this issue to me?

@neolit123
Copy link
Member Author

@SupriyaSirbi there are already PRs in progress here from @vincepri :
#693
kubernetes-sigs/controller-runtime#298

/lifecycle active
/assign @vincepri

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 18, 2019
@neolit123
Copy link
Member Author

neolit123 commented Jan 18, 2019 •
edited
Loading

/priority important-longterm
/remove-priority backlog

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jan 18, 2019
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
@k8s-ci-robot
Merge pull request kubernetes-sigs#688 from codenrhoden/update-ovas
02afd1b 
Update OVA links in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincepri vincepri

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Master -> Control Plane vincepri/cluster-api
4 participants
@neolit123 @vincepri @SupriyaSirbi @k8s-ci-robot