-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider "false" value when evaluating "bool" annotations #7434
Comments
/triage accepted |
/assign |
Are there some examples that supporting |
@vincepri the idea we discussed when this issue was filed was that in the (rare) event where a new user w/ pre-existing Kubernetes infrastructure adopts Cluster API, they may already be using CAPI annotations for previous use in a negative sense, and if so we should respect that. I don't remember the exact conversation, but (despite the fact that I filed this issue!) I would prefer that CAPI standardize to requiring significance for both key + value in any capi-specific annotations to avoid collisions w/ pre-existing usage of those annotations across the Kubernetes ecosystem. Because there's no standard set of "Kubernetes annotations", we can't guarantee uniqueness when we come up w/ a new, CAPI-specific annotation. In any event this issue is a good thread to have this conversation for folks who are interested. |
But aren't CAPI specific annotations namespaced to our namespace? I think that should guarantee that nobody else defined them before. Nobody else should define annotations in our namespace |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
/priority backlog |
The Cluster API project currently lacks enough active contributors to adequately respond to all issues and PRs.
We can reopen if conditions arises + someone volounteers |
@fabriziopandini: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
User Story
As a user I would like existing annotations annotations explicitly set to "false" to be respected as false in Cluster API.
Detailed Description
For annotations where we simply look for the presence of a well-known key to indicate true/false, we should consider enabling support for explicit "false" indicators. The most obvious is the value of
"false"
in the value of the existent annotation.[A clear and concise description of what you want to happen.]
Anything else you would like to add:
This precedent was established as a part of this PR: #7107
[Miscellaneous information that will assist in solving the issue.]
/kind feature
The text was updated successfully, but these errors were encountered: