switch machine controller tests that use SSA to envtest and drop disableNodeLabelSync

[ykakarap]

Detailed Description

The machine controller disables portions of its reconciliation logic that depend on SSA by setting disableNodeLabelSync to true during tests. This is because the current test setup for the machine controller uses fake client which does not support SSA.

This issue to switch over the tests, at least the ones that need a working SSA, to envtest and dropping the disableNodeLabelSync from the machine reconciler.

/kind test

[k8s-ci-robot]

@ykakarap: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

Detailed Description

The machine controller disables portions of its reconciliation logic that depend on SSA by setting disableNodeLabelSync to true during tests. This is because the current test setup for the machine controller uses fake client which does not support SSA.

This issue to switch over the tests, at least the ones that need a working SSA, to envtest and dropping the disableNodeLabelSync from the machine reconciler.

/kind test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ykakarap]

/area testing

[sbueringer]

Not sure if it is implied or not.

Let's please also consider splittung up the code so we would only have to implement a small part of our tests with envtest (and to improve code structure)

All the pre-existing tests that have nothing to do with node label sync don't necessary have to be migrated to envtest.

[sbueringer]

/triage accepted

[ykakarap]

/milestone v1.4

[k8s-ci-robot]

@ykakarap: You must be a member of the kubernetes-sigs/cluster-api-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/assign