Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context to reconciler event handlers #8054

Closed
killianmuldoon opened this issue Feb 3, 2023 · 4 comments
Closed

Add context to reconciler event handlers #8054

killianmuldoon opened this issue Feb 3, 2023 · 4 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@killianmuldoon
Copy link
Contributor

With the release of the next version of controller runtime event handlers will be able to take a real context - kubernetes-sigs/controller-runtime#2139.

Currently our reconciler event handlers - e.g. mapping functions for Watches - are using context.TODO(). With the next release of Controller Runtime we can (and should) replace them with real context objects.

/kind cleanup
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 3, 2023
@killianmuldoon
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 3, 2023
@sbueringer
Copy link
Member

Thx for opening an issue. I'll add a sub-task in my umbrella issue.
It's currently focused on CR v0.14 but I'm already collection things for v0.15 there and will split it up soon.

(xref: #7925)

@sbueringer
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbueringer @k8s-ci-robot @killianmuldoon