-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for KubeadmConfigSpec defaulting #8147
Comments
@vincepri @fabriziopandini @ykakarap The unit tests sounds sufficient and pretty straightforward to me, WDYT? |
Yup, unit test looks like a good idea. +1. |
/triage accepted |
@fabriziopandini: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Let's see if some takes this over. I added it to the v1.5 milestone to ensure we'll implement it until then. I would take over if nobody volunteers until then. |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
/triage accepted |
We repeatedly had the issue that we added new defaulting to KubeadmConfigSpec fields, which lead to rollouts in KCP after CAPI upgrade:
The goal of this issue is to add some sort of validation that we can run as part of presubmits to ensure this doesn't happen again.
We basically want to validate that all defaulting that we implement for
KubeadmConfigSpec
is done inDefaultKubeadmConfigSpec
and not via OpenAPI.Some ideas:
KubeadmConfig.Default()
vs. KubeadmConfig create with envtest// +kubebuilder:default
marker inKubeadmConfigSpec
struct and below (controller-tools based linter)/kind feature
/area control-plane
The text was updated successfully, but these errors were encountered: