Drop disableInPlacePropagation from KCP reconciler and migrate the affected tests to envtest.

[ykakarap]

Detailed Description:

The KubeadmControlPlaneReconciler has a additional disableInPlacePropagation which is sued to disable some of the parts of the controller that depend on SSA during tests. This flag is only used during testing and does not affect the controllers behavior in anyway.

This issue to track the work to drop the this flag from the controller and migrate all the affected tests.

Additional Information:

Once the flag is dropped the tests will fail because they use fakeClient which does not support Server-Side-Apply. All of the affected tests should be migrated to using envtest (supports SSA).

/area testing

[fabriziopandini]

Note: we are talking about migration of tests to env tests (which uses a real API server, and this fully support SSA)

/triage accepted
/help

[k8s-ci-robot]

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Note: we are talking about migration of tests to env tests (which uses a real API server, and this fully support SSA)

/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.