Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Configuring Kubelet in Cluster API #8425

Closed
killianmuldoon opened this issue Mar 30, 2023 · 8 comments · Fixed by #8678
Closed

Docs: Configuring Kubelet in Cluster API #8425

killianmuldoon opened this issue Mar 30, 2023 · 8 comments · Fixed by #8678
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@killianmuldoon
Copy link
Contributor

What would you like to be added (User Story)?

As a user I would like to understand how to configure Kubelet when deployed in a Cluster API cluster using KCP and CAPBK.

Detailed Description

Currently there's a few different approaches:

  1. Write a Kubelet conf using CloudInit files
  2. Add Kubelet extraArgs in the KubeadmConfigTemplate
  3. Patch kubeletconfiguration using a Kubeadm patch defined in the KubeadmConfigTemplate

The documentation should layout basic examples of each approach, and detail the limitations of each.

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
/kind documentation

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/documentation Categorizes issue or PR as related to documentation. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 30, 2023
@fabriziopandini
Copy link
Member

/triage accepted
/help

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 31, 2023
@musaprg
Copy link
Member

musaprg commented Apr 21, 2023

Hi, I'd like to work on this. Let me try to prepare a PR for it.

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Apr 21, 2023
@killianmuldoon
Copy link
Contributor Author

@musaprg - awesome, looking forward to seeing what you come up with!

@musaprg
Copy link
Member

musaprg commented Apr 28, 2023

I'm considering where I should put the document. I think putting it under https://cluster-api.sigs.k8s.io/tasks/bootstrap/kubeadm-bootstrap.html would be best.

@killianmuldoon
Copy link
Contributor Author

That makes sense to me.

@guettli
Copy link
Contributor

guettli commented May 2, 2023

Please consider this use case: I you want to set system-reserved during the execution of preKubeadmCommands.

The script detects the amount of mem and cpu, and then sets the value accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants