Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MachinePool Machines in CAPD #9096

Closed
Jont828 opened this issue Jul 31, 2023 · 4 comments
Closed

Add support for MachinePool Machines in CAPD #9096

Jont828 opened this issue Jul 31, 2023 · 4 comments
Assignees
Labels
area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Jont828
Copy link
Contributor

Jont828 commented Jul 31, 2023

What would you like to be added (User Story)?

As a developer, I'd like to have DockerMachinePools support MachinePool Machines by leveraging the new logic in CAPI core. This way, other providers have an example implementation to follow.

Detailed Description

Since MachinePool Machines have landed in CAPI core, we want to also include changes in CAPD to implement it. Now that we can use DockerMachines with MachinePools, we can also clean up a lot of redundant code by reusing the same logic as well.

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 31, 2023
@sbueringer sbueringer added the area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider label Aug 2, 2023
@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 2, 2023
@Jont828
Copy link
Contributor Author

Jont828 commented Oct 17, 2023

Note: we also want to include the DockerMachines for metadata propogation so that the labels added to the MachinePool Machine are added to the DockerMachine as well.

@CecileRobertMichon
Copy link
Contributor

This was done in #8842

/close

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closing this issue.

In response to this:

This was done in #8842

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants