Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide a migration path for deprecated certManagerVersionAnnotation #9145

Open
furkatgofurov7 opened this issue Aug 8, 2023 · 7 comments
Open
Labels
area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Aug 8, 2023

What steps did you take and what happened?

We have a certManagerVersionAnnotation = "certmanager.clusterctl.cluster.x-k8s.io/version annotation which is maintained only for supporting upgrades from clusters created with clusterctl v1alpha3. We are working towards removing a previously deprecated code in #9136 and this annotation might not be removed since there is no migration code for it and we have to keep it in order to support clusters created with this annotation.

What did you expect to happen?

We need to decide how we would provide a clear migration tasks for this specific annotation not to break clusters created with v1alpha3

Cluster API version

main

Kubernetes version

N/A

Anything else you would like to add?

See more the discussion here: #9136 (comment)

Label(s) to be applied

/kind bug
/area clusterctl

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 8, 2023
@furkatgofurov7
Copy link
Member Author

/area clusterctl

/cc @killianmuldoon FYI

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Aug 8, 2023
@killianmuldoon
Copy link
Contributor

Thanks for opening this @furkatgofurov7

/assign

I'll take a look at figuring out the current state of this.

@furkatgofurov7
Copy link
Member Author

/assign

I'll take a look at figuring out the current state of this.

@killianmuldoon thanks!

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 8, 2023
@killianmuldoon
Copy link
Contributor

/unassign

Not going to get to this for now.

@fabriziopandini
Copy link
Member

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 11, 2024
@fabriziopandini
Copy link
Member

This needs someone to look into
/help

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

This needs someone to look into
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants