Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine which resources are blocking clusterctl move during discovery #9196

Closed
nojnhuh opened this issue Aug 16, 2023 · 2 comments · Fixed by #9246
Closed

Determine which resources are blocking clusterctl move during discovery #9196

nojnhuh opened this issue Aug 16, 2023 · 2 comments · Fixed by #9246
Assignees
Labels
area/clusterctl Issues or PRs related to clusterctl kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 16, 2023

What would you like to be added (User Story)?

As a developer I want to better align the process for determining if a resource is blocking a clusterctl move operation with other inputs to increase overall consistency.

Detailed Description

The first iteration of allowing resources to block a clusterctl move operation by #8690 requires at least one extra API call for every resource to determine if the resource is blocking the move. Instead, the initial state could be gathered during the discovery phase which would enable tighter short-circuiting where no extra API calls are required for resources not blocking a move.

Anything else you would like to add?

No response

Label(s) to be applied

/kind cleanup
/area clusterctl

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/clusterctl Issues or PRs related to clusterctl needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 16, 2023
@fabriziopandini
Copy link
Member

/triage accepted

echoing here #8690 (comment)

@nojnhuh it would be great to get #9196 implemented before 1.6.0 is cut, because the current implementation is adding an unnecessary extra get for all the objects + the user can wait for x times the timeout for waitMove.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 17, 2023
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 17, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants