-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation issue with using ignition as a bootstrap configuration #9402
Comments
@odvarkadaniel: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area documentation |
/triage accepted Thanks for reporting this! /help |
@killianmuldoon: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ping @tormath1 |
Would an acceptable solution to this be a change of the k8s version in the commend to |
How about we bump it to 1.28.1 already, since I guess they will be removed later in the future than v1.25.0? I'm pretty sure v1.22.2 existed at some point, so I assume those AMIs are now removed due to being EOL. |
Thanks for raising this issue. I think the version should be the same as the one in the "getting started" common book: https://cluster-api-aws.sigs.k8s.io/getting-started#generating-the-cluster-configuration. We can update clusterctl generate cluster ignition-cluster \
--from https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/templates/cluster-template-flatcar.yaml \
- --kubernetes-version **v1.22.2** \
+ --kubernetes-version $(curl -Ls https://dl.k8s.io/release/stable.txt) \
--worker-machine-count 2 \
> ignition-cluster.yaml |
genius. more docs should do this. |
Is there any guarantee that an image exists for every stable version of Kubernetes? We may also not have support for a given minor version in Kubernetes - it can take time to catch up and older release branches which will have this documentation will certainly not support the latest version of Kubernetes. I think if we want to keep this documentation from being broken the target should be keeping this version the same as the version used by the regular CAPI quickstart, but we'd need some guarantee that those AMIs will be available. |
I guess every major stable version should be guaranteed to have an AMI? So therefore we could just modify the command that @tormath1 posted above as:
So we always end up with a major version of k8s. |
/assign |
What steps did you take and what happened?
I was following this part of the CAPI book to use ignition as a bootstrap config for my control plane machine for a workload cluster, but I run in to an issue where the AMI with the name
capa-ami-flatcar-stable-?1.22.2-*
does not exist.The
clusterctl
command that is being used to generate the workload cluster is using unsupported version for this feature:The kubernetes version should be v1.25.0+.
What did you expect to happen?
I expected my control plane machine to get to phase Running.
Cluster API version
v1.5.0
Kubernetes version
No response
Anything else you would like to add?
Not really a bug, but an error in the documentation as the AMI exists only for versions v1.25.0+ according to this list.
Label(s) to be applied
/label area/documentation
The text was updated successfully, but these errors were encountered: