-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing support for "clusterctl.cluster.x-k8s.io/move" label since v1alpha4 #9630
Comments
/triage accepted There's definitely a bug in the implementation here - thanks for catching it. I think there's two seperate issues.
AFAICT neither of these cases are working right now and we need a fix. /help |
@killianmuldoon: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
@killianmuldoon Did #9694 fix (only) 1? |
According to #9694 (comment) both cases were working for the user. I'm not sure if it's tested properly though. I think we should add a help wanted here and get someone to ensure the tests are covering that case. /help |
#9694 should have fixed both, we can eventually re-open if someone reports issues again |
@fabriziopandini: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What steps did you take and what happened?
Hi!
I'm using custom Secret to provide credentials for OpenStack infrastructure provider.
Applied manifest like this (with
clusterctl.cluster.x-k8s.io/move: "true"
label, according to docs):But during
clusterctl move --to-kubeconfig=kube.yaml --namespace capi-management-cluster --dry-run -v 10
I run into this line in logs:
Excluding secret from move (not linked with any Cluster) name="capi-clouds-config-secret"
and have secret skipped (breaking provider reconciliation in target cluster).What did you expect to happen?
Secret with
clusterctl.cluster.x-k8s.io/move: "true"
label should also be moved into target clusterCluster API version
1.5.3
Kubernetes version
v1.27.6
Anything else you would like to add?
Seems like tracking
clusterctl.cluster.x-k8s.io/move
label was dropped since v1alpha4 (API for v1alpha3 still containsClusterctlMoveLabel
mentions).However, label still is mentioned in docs: https://cluster-api.sigs.k8s.io/clusterctl/provider-contract.html#move
Label(s) to be applied
/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
The text was updated successfully, but these errors were encountered: