Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge finalizer tests with default quick start tests #9636

Closed
killianmuldoon opened this issue Oct 30, 2023 · 2 comments · Fixed by #10039
Closed

Merge finalizer tests with default quick start tests #9636

killianmuldoon opened this issue Oct 30, 2023 · 2 comments · Fixed by #10039
Assignees
@adityabhatia
Labels
area/e2e-testing Issues or PRs related to e2e testing triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@killianmuldoon
Copy link
Contributor

#9471 introduced new tests to check that finalizers were correctly re-reconciled in Cluster API.

After a week of runs there's been no failures in this test. We should consider merging these tests with the basic CAPI e2e tests in order to reduce the total number of tests we run and the length of the e2e-full test run.

Let's gather another week of data before moving ahead with this, and consider merging after Nov. 6th.

Ref: #9471 (review)
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 30, 2023
@killianmuldoon
Copy link
Contributor Author

/triage accepted

@adityabhatia in case you want to pick this up 🙂.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 30, 2023
@adityabhatia
Copy link
Contributor

/triage accepted

@adityabhatia in case you want to pick this up 🙂.

Sure 🙂
/assign

@sbueringer sbueringer added the area/e2e-testing Issues or PRs related to e2e testing label Oct 30, 2023
This was referenced Jan 23, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityabhatia adityabhatia

Labels
area/e2e-testing Issues or PRs related to e2e testing triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 test: combine Finalizers tests to default quick start tests adityabhatia/cluster-api
4 participants
@sbueringer @adityabhatia @k8s-ci-robot @killianmuldoon