-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 test: combine Finalizers tests to default quick start tests #10039
🌱 test: combine Finalizers tests to default quick start tests #10039
Conversation
Hi @adityabhatia. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold should wait for #10029 |
@adityabhatia I think you have to change "Fixes # #9636" to "Fixes #9636" (assuming you want to close the issue with this PR) |
/ok-to-test |
e48aae2
to
7acf845
Compare
Rebased. |
/test pull-cluster-api-e2e-full-main |
Thx! /lgtm Let's just wait 2-3 days to get more data on main to confirm the finalizer tests are absolutely stable. |
LGTM label has been added. Git tree hash: 9adc781cc49b6d1e67e3a5977902e8d589f18ccd
|
/approve /hold |
7acf845
to
53b607c
Compare
Since the quick start tests have been running quite stable for a while, should we merge this? |
Let's finally get this in. /lgtm |
LGTM label has been added. Git tree hash: c50fff18e58d1bb396644cd73a7cab56e2d85d81
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up on this!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9636
/area e2e-testing