Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Machine / InfraMachine / BootstrapConfig with the same name #9733

Closed
sbueringer opened this issue Nov 16, 2023 · 2 comments · Fixed by #9833
Closed

Generate Machine / InfraMachine / BootstrapConfig with the same name #9733

sbueringer opened this issue Nov 16, 2023 · 2 comments · Fixed by #9833
Assignees
@sbueringer
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

Today we generate separate random names for Machine / InfraMachine / BootstrapConfig in KCP and the MachineSet controller. This makes it unnecessarily complicated to correlate these objects as an operator.

The idea is that we should only create one random name on Machine create and then use it for all 3 objects
@sbueringer
Copy link
Member Author

cc @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 16, 2023
@fabriziopandini
Copy link
Member

/triage accepted

cc @vincepri @CecileRobertMichon
This is a relatively simple change that improves usability and makes troubleshooting easier.
opinions?

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 17, 2023
@sbueringer sbueringer self-assigned this Nov 20, 2023
@sbueringer sbueringer mentioned this issue Dec 8, 2023
Merged
@chrischdi chrischdi mentioned this issue Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbueringer sbueringer

Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@sbueringer @fabriziopandini @k8s-ci-robot