-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusterclass control-plane namingStrategy is not applied for Azure cluster #10754
Comments
This issue is currently awaiting triage. If CAPI contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
introduced the naming strategy, which applies to the objects and made it into CAPI v1.5.x (cherry-pick) and v1.6:
Part of it was not to apply the same naming also for the objects created by the above objects. The following issue/PR:
introduced a change to re-use the naming from the upper objects to the objects they create and made it into v1.7.0.
So beginning with v1.7.0 you should have your expected behaviour. |
Hi @chrischdi, Thanks for your feedback. |
So I guess we can close this @arno-pons ? :-) |
Yes of course. We will try with v1.7.0 version ASAP and let you know if we still have issue 😄. Thanks. |
@arno-pons friendly reminder: do you have any results to share :-) |
/close |
@fabriziopandini: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What steps did you take and what happened?
Deploying an Azure cluster using a clusterclass with a spec.controlPlane.namingStrategy.template attribute with value:
"{{ .cluster.name }}-control-plane-{{ .random }}"
doesn't create capz objects name (azuremachinetemplate, azuremachine and azure VM) matching this strategy.
Only capi objects (kubeadmcontrolplane and machine) are correctly named.
capz objects seems to be named with default strategy:
"{{ .cluster.name }}-{{ .random }}"
Here the clusterclass configuration:
What did you expect to happen?
Names of control-plane VM and nodes should match clusterclass namingStrategy.
Cluster API version
Kubernetes version
Anything else you would like to add?
clusterclass with same namingStrategy for another infrastructure provider (vSphere capv) results in VM and node names matching the naming strategy.
Same issue has been opened on capz provider side:
kubernetes-sigs/cluster-api-provider-azure#4597
Label(s) to be applied
/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
The text was updated successfully, but these errors were encountered: