Remove occurences of conditions.WithStepCounterIf(false)

[CecileRobertMichon]

conditions.WithStepCounterIf(false) doesn't seem to do anything as we always pass in false (?)
If I'm right, let's get rid of all other occurences of this (ideally in a separate PR I think)

Following up from @sbueringer's comment in #9725, we should check if we can remove all occurrences of WithStepCounterIf when the bool parameter is hardcoded to false.

[sbueringer]

/triage accepted

/help

[k8s-ci-robot]

@sbueringer:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mcbenjemaa]

/assign

[CecileRobertMichon]

@mcbenjemaa there are a couple more occurrences of conditions.WithStepCounterIf(false) in the codebase, e.g. in the MachinePool controller, do you want to take a stab at removing those as well?

/reopen

[k8s-ci-robot]

@CecileRobertMichon: Reopened this issue.

In response to this:

@mcbenjemaa there are a couple more occurrences of conditions.WithStepCounterIf(false) in the codebase, e.g. in the MachinePool controller, do you want to take a stab at removing those as well?

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mcbenjemaa]

I will take a look.

[sbueringer]

@CecileRobertMichon Are you sure? I checked during review and now again and I can't find them.

[mcbenjemaa]

The hardcoded conditions are removed, but do you mean replacing the other ones?

[CecileRobertMichon]

Oh I guess it's because #9725 hasn't merged yet...

I can remove the occurrence it's adding in the PR then, all good! Thank you @mcbenjemaa

/close

[k8s-ci-robot]

@CecileRobertMichon: Closing this issue.

In response to this:

Oh I guess it's because #9725 hasn't merged yet...

I can remove the occurrence it's adding in the PR then, all good! Thank you @mcbenjemaa

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.